Re: [DynInst_API:] [dyninst/dyninst] 4f5716: Remove support for building on Windows

[Tim Haines <thaines@xxxxxxxxxxx>]

This just removes the CMake side of things which hasn't work since 2016; 
proccontrol hasn't been buildable since 2012. None of the 
Windows-specific source files have been removed. Building on Windows 
will required many CMake updates, so this commit can be referred to when 
that needs to happen.
Thanks.
- Tim


On 8/13/22 2:28 PM, BARTON P MILLER wrote:
> Tim,
>
> Weâre going to want to save some of the old Windows code. There may be a security project coming up that needs to revive that code.
>
> âbart
>
> > On Aug 13, 2022, at 2:23 PM, Tim Haines <noreply@xxxxxxxxxx> wrote:
> >
> > ï  Branch: refs/heads/thaines/cmake_modernization
> >   Home:   https://github.com/dyninst/dyninst
> >   Commit: 4f57162523cb8212bbcad38729968f621cefee3e
> >       https://github.com/dyninst/dyninst/commit/4f57162523cb8212bbcad38729968f621cefee3e
> >   Author: Tim Haines <thaines.astro@xxxxxxxxx>
> >   Date:   2022-08-13 (Sat, 13 Aug 2022)
> >
> >   Changed paths:
> >     M CMakeLists.txt
> >     M cmake/Boost.cmake
> >     M cmake/ElfUtils.cmake
> >     M cmake/LibIberty.cmake
> >     M cmake/ThreadingBuildingBlocks.cmake
> >     M cmake/cap_arch_def.cmake
> >     M cmake/optimization.cmake
> >     M cmake/platform.cmake
> >     M cmake/shared.cmake
> >     M cmake/warnings.cmake
> >     M common/CMakeLists.txt
> >     M dwarf/CMakeLists.txt
> >     M dyninstAPI/CMakeLists.txt
> >     M dyninstAPI_RT/CMakeLists.txt
> >     M elf/CMakeLists.txt
> >     M proccontrol/CMakeLists.txt
> >     M stackwalk/CMakeLists.txt
> >     M symlite/CMakeLists.txt
> >     M symtabAPI/CMakeLists.txt
> >
> >   Log Message:
> >   -----------
> >   Remove support for building on Windows
> >
> > dyninstAPI/src/pdwinnt.C includes dyninstAPI/src/PCEventMuxer.h which
> > was added by 0088b12 on June 05,2012 and then renamed by 7c987bc on June
> > 06, 2012 without updating pdwinnt.C. CMake support for Windows was added
> > by f0195a8 in June 2013. Hence, proccontrol was never buildable using
> > CMake. The VS project files used by 'include_external_msproject' were
> > deleted by 5c88375a7 in 2016.
> >
> >
> > _______________________________________________
> > Dyninst-api mailing list
> > Dyninst-api@xxxxxxxxxxx
> > https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api