Date: | Fri, 25 Mar 2022 12:29:44 -0700 |
---|---|
From: | kupsch <noreply@xxxxxxxxxx> |
Subject: | [DynInst_API:] [dyninst/dyninst] 377113: Fix warnings with cmake's MINSIZEREL build type |
Branch: refs/heads/kupsch/fix-warnings-MINSIZEREL Home: https://github.com/dyninst/dyninst Commit: 377113459bcb6d5e54536412a013291df1045167 https://github.com/dyninst/dyninst/commit/377113459bcb6d5e54536412a013291df1045167 Author: James A. Kupsch <kupsch@xxxxxxxxxxx> Date: 2022-03-25 (Fri, 25 Mar 2022) Changed paths: M cmake/optimization.cmake Log Message: ----------- Fix warnings with cmake's MINSIZEREL build type - Explicitly define optimization flags for cmake's MINSIZEREL build type. Cmake by default includes -DNDEBUG. This results in assert being defined to do nothing. Dyninst use asserts as a fatal error reporting mechanism and expects assert to not return if the condition is always false. If assert can return then many warnings are produced due to this unexpect path. - Remove defining NDEBUG for REL build types if using the MSC compiler |
[← Prev in Thread] | Current Thread | [Next in Thread→] |
---|---|---|
|
Previous by Date: | [DynInst_API:] [dyninst/dyninst] cf3a2a: fix warnings in MINSIZEREL build types, kupsch |
---|---|
Next by Date: | [DynInst_API:] [dyninst/dyninst] 474ab1: Fix warnings with cmake's MINSIZEREL build type (#..., kupsch |
Previous by Thread: | [DynInst_API:] [dyninst/dyninst] 3699a8: Revert "Temporarily enable pr build", Tim Haines |
Next by Thread: | [DynInst_API:] [dyninst/dyninst] 393754: Remove outdated Boost version checks (#1329), Tim Haines |
Indexes: | [Date] [Thread] |