[DynInst_API:] [dyninst/dyninst] bf6328: Clean up BPatch::createEnum

[Tim Haines <noreply@xxxxxxxxxx>]

  Branch: refs/heads/thaines/improve_dwarf_enum_handling
  Home:   https://github.com/dyninst/dyninst
  Commit: bf632838804688c154a1bfb1678574208958d9d5
      https://github.com/dyninst/dyninst/commit/bf632838804688c154a1bfb1678574208958d9d5
  Author: Tim Haines <thaines@xxxxxxxxxxx>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    M dyninstAPI/src/BPatch.C
    M symtabAPI/h/Type.h
    M symtabAPI/src/Type.C

  Log Message:
  -----------
  Clean up BPatch::createEnum

This removes the unnecessary construction of a separate (thread-safe!)
container of pairs and the associated memory leaks. It also explicitly
makes the enum's underlying type a four-byte signed int. Redundant code
from the overload which computes the enum values was replaced by using
std::iota and calling the three-argument createEnum.


  Commit: c76a0d282a058b67fc07d32388fae5d7348c1924
      https://github.com/dyninst/dyninst/commit/c76a0d282a058b67fc07d32388fae5d7348c1924
  Author: Tim Haines <thaines@xxxxxxxxxxx>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    M symtabAPI/h/Type.h
    M symtabAPI/src/Type.C

  Log Message:
  -----------
  Remove factory functions

Adding overloads for these would add more clutter than utility. We
should remove these from all of the types as the constructors should
always be used to ensure class invariants.


  Commit: bf7f9700804eb41a7eabc81b946df6cb4511a0d1
      https://github.com/dyninst/dyninst/commit/bf7f9700804eb41a7eabc81b946df6cb4511a0d1
  Author: Tim Haines <thaines@xxxxxxxxxxx>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    M symtabAPI/h/Type.h
    M symtabAPI/src/Type.C

  Log Message:
  -----------
  Remove non-portable constructors

Since we're breaking ABI here, these constructors need to go. Manually
setting the size to `sizeof(int)` is non-portable as the
BPatch::createEnum may be used to modify a binary that doesn't have the
same `int` representation as the host on which Dyninst was compiled.


Compare: https://github.com/dyninst/dyninst/compare/6bcd69af73f5...bf7f9700804e