[DynInst_API:] [dyninst/dyninst] d726a3: Fix memory leak in singleton_object_pool


Date: Tue, 08 Sep 2020 11:34:22 -0700
From: noreply@xxxxxxxxxx
Subject: [DynInst_API:] [dyninst/dyninst] d726a3: Fix memory leak in singleton_object_pool
  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: d726a3dd3bb55705a6116b5aea15a09d1d587bb4
      https://github.com/dyninst/dyninst/commit/d726a3dd3bb55705a6116b5aea15a09d1d587bb4
  Author: Xiaozhu Meng <mxz297@xxxxxxxxx>
  Date:   2020-09-05 (Sat, 05 Sep 2020)

  Changed paths:
    M common/src/singleton_object_pool.h
    M instructionAPI/src/InstructionDecoder-aarch64.C
    M instructionAPI/src/InstructionDecoder-aarch64.h
    M instructionAPI/src/InstructionDecoder-power.C
    M instructionAPI/src/InstructionDecoder-power.h
    M instructionAPI/src/InstructionDecoderImpl.C
    M instructionAPI/src/InstructionDecoderImpl.h

  Log Message:
  -----------
  Fix memory leak in singleton_object_pool


  Commit: fe036ca29689466a6627051242c54c644b196f91
      https://github.com/dyninst/dyninst/commit/fe036ca29689466a6627051242c54c644b196f91
  Author: Xiaozhu Meng <mxz297@xxxxxxxxx>
  Date:   2020-09-06 (Sun, 06 Sep 2020)

  Changed paths:
    M instructionAPI/src/InstructionDecoder-aarch64.C

  Log Message:
  -----------
  Fix aarch64 instruction decoding regression


  Commit: 992353b21923bf5406176040dc3663fea270a87b
      https://github.com/dyninst/dyninst/commit/992353b21923bf5406176040dc3663fea270a87b
  Author: Xiaozhu Meng <mxz297@xxxxxxxxx>
  Date:   2020-09-06 (Sun, 06 Sep 2020)

  Changed paths:
    M instructionAPI/src/InstructionDecoder-power.C

  Log Message:
  -----------
  Fix power instruction decoding regression


  Commit: c31fddaf7e062e64d1993b6565d47fd307c8289f
      https://github.com/dyninst/dyninst/commit/c31fddaf7e062e64d1993b6565d47fd307c8289f
  Author: Tim Haines <thaines.astro@xxxxxxxxx>
  Date:   2020-09-08 (Tue, 08 Sep 2020)

  Changed paths:
    M common/src/singleton_object_pool.h
    M instructionAPI/src/InstructionDecoder-aarch64.C
    M instructionAPI/src/InstructionDecoder-aarch64.h
    M instructionAPI/src/InstructionDecoder-power.C
    M instructionAPI/src/InstructionDecoder-power.h
    M instructionAPI/src/InstructionDecoderImpl.C
    M instructionAPI/src/InstructionDecoderImpl.h

  Log Message:
  -----------
  Fix memory leak in singleton_object_pool (#835)

Two memory leak fixes related singleton_object_pool.

    1. The singleon_object_pool currently only destructs objects but does not deallocate memory space. This leak applies to all architectures.

    2. On ppc and arm, instruction decoder does not use smart pointers to manage InstructionAPI::Instruction constructed by a singleon_object_pool, and thus cause memory leaks.


Compare: https://github.com/dyninst/dyninst/compare/a3f90e0e287f...c31fddaf7e06
[← Prev in Thread] Current Thread [Next in Thread→]