[DynInst_API:] [dyninst/dyninst] e627ff: Libxul fixes (#755)

[noreply@xxxxxxxxxx]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: e627ffbf93af454792ca16471a26cb6d3b0c3bc7
      https://github.com/dyninst/dyninst/commit/e627ffbf93af454792ca16471a26cb6d3b0c3bc7
  Author: Xiaozhu Meng <mxz297@xxxxxxxxx>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M dataflowAPI/rose/x86_64InstructionSemantics.h
    M parseAPI/h/CFG.h
    M parseAPI/src/Block.C
    M parseAPI/src/Parser.C
    M parseAPI/src/Parser.h
    M parseAPI/src/ParserDetails.C
    M parseAPI/src/SymtabCodeSource.C

  Log Message:
  -----------
  Libxul fixes (#755)

* Don't abort for instruction semantic errors.

Define ROSE_ASSERT so that a signal is thrown for instruction
semantic errors instead of doing an assertion abort.

* 1. Clean dead code
2. Fix typo regarding to non-returning functions
3. The moving of edges for block split should be protected with a lock

* Fix block split for inconsistent cases

* Add more debug print

* Add debug print for knownData

* Ignore data symbols in .text sections. These are probably wrong symbol table information.

Co-authored-by: Stan Cox <scox@xxxxxxxxxx>