[DynInst_API:] [dyninst/dyninst] a58103: Fix for crashing on relocating at unistrumentable ...

[Benjamin Welton <welton@xxxxxxxxxxx>]

  Branch: refs/heads/master
  Home:   https://github.com/dyninst/dyninst
  Commit: a58103fb2c7c000c87a2c0ce9b1118061067dfde
      https://github.com/dyninst/dyninst/commit/a58103fb2c7c000c87a2c0ce9b1118061067dfde
  Author: Benjamin Welton <welton@xxxxxxxxxxx>
  Date:   2018-05-01 (Tue, 01 May 2018)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C

  Log Message:
  -----------
  Fix for crashing on relocating at unistrumentable points

This fix is to address issue #455. When an unistrimentable point is selected for instrimenation
the behaviour Dyninst will now exhibit is the following:

1. InsertSnippet will return NULL if not in an insertion set and an illegal when parameter is used

2. If in an insertion set, InsertSnippet will return an object to the instrimentation. However when the set
   is closed the insertion of that point will fail. It will either fail and continue to the next point (if
   the insertion set closure is set to continue past errors) or roll back all prior insertions.
.


  Commit: d830b0645852727ab59909d110ebf24c6a29056b
      https://github.com/dyninst/dyninst/commit/d830b0645852727ab59909d110ebf24c6a29056b
  Author: Benjamin Welton <welton@xxxxxxxxxxx>
  Date:   2018-10-02 (Tue, 02 Oct 2018)

  Changed paths:
    M dyninstAPI/src/Relocation/Widgets/InstWidget.C

  Log Message:
  -----------
  Merge pull request #460 from bwelton/inst_fix

Fix for crashing on relocating at unistrumentable points. Fix checks whether a parameter is NULL or not, if it is NULL it does not perform the instrumentation.


Compare: https://github.com/dyninst/dyninst/compare/93e7cd171f00...d830b0645852
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.