[DynInst_API:] new getCompDir is broken


Date: Wed, 04 Apr 2018 17:12:35 -0500
From: "Mark W. Krentel" <krentel@xxxxxxxx>
Subject: [DynInst_API:] new getCompDir is broken
Sasha,

I see where you added a method to Module for getCompDir().

Thanks, but the implementation is badly broken.  This has to be a
per-module answer.  But the code for getCompDir() has a single static
string comp_dir_str.  As a result, every Module returns the same comp
dir.

Instead, I think you want to store the comp_dir_string as a private
string inside Module, similar to the private strings for fileName and
fullName.

--Mark

[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] new getCompDir is broken, Mark W. Krentel <=