Date: | Wed, 04 Apr 2018 17:12:35 -0500 |
---|---|
From: | "Mark W. Krentel" <krentel@xxxxxxxx> |
Subject: | [DynInst_API:] new getCompDir is broken |
Sasha, I see where you added a method to Module for getCompDir(). Thanks, but the implementation is badly broken. This has to be a per-module answer. But the code for getCompDir() has a single static string comp_dir_str. As a result, every Module returns the same comp dir. Instead, I think you want to store the comp_dir_string as a private string inside Module, similar to the private strings for fileName and fullName. --Mark |
[← Prev in Thread] | Current Thread | [Next in Thread→] |
---|---|---|
|
Previous by Date: | Re: [DynInst_API:] change in getFile from libdwarf to libdw, Mark W. Krentel |
---|---|
Next by Date: | [DynInst_API:] [dyninst/dyninst] 34c5f5: Correcting declaration of variable for the value o..., Sasha Nicolas |
Previous by Thread: | Re: [DynInst_API:] modify register contents in dyninst, Bill Williams |
Next by Thread: | [DynInst_API:] new-parallel-parsing config is broken for testsuite, Mark W. Krentel |
Indexes: | [Date] [Thread] |