Re: [DynInst_API:] commit: v9.0.x and v9.1.x branches


Date: Thu, 22 Oct 2015 13:21:54 -0700
From: Josh Stone <jistone@xxxxxxxxxx>
Subject: Re: [DynInst_API:] commit: v9.0.x and v9.1.x branches
On 10/22/2015 11:58 AM, Bill Williams wrote:
> Reorganized Monday's commits into 9.0.x (everything but the module 
> changes) and 9.1.x (module changes only, thus far) branches. They'll 
> both get merged back to master post-releases.

Better, thanks!

There's one more break that snuck into v9.0.x:

$ git diff v9.0.3 */h/
diff --git a/symtabAPI/h/Symtab.h b/symtabAPI/h/Symtab.h
index 078a1d5304f8..babbe5a8eb14 100644
--- a/symtabAPI/h/Symtab.h
+++ b/symtabAPI/h/Symtab.h
@@ -363,8 +363,8 @@ class SYMTAB_EXPORT Symtab : public LookupInterface,

    std::string getDefaultNamespacePrefix() const;

-   unsigned getNumberofRegions() const;
-   unsigned getNumberofSymbols() const;
+   unsigned getNumberOfRegions() const;
+   unsigned getNumberOfSymbols() const;

    std::vector<std::string> &getDependencies();
    bool removeLibraryDependency(std::string lib);


I don't object this in later sonames, but for now it's an ABI break.

I'll use libabigail's abidiff to see if there's anything else, but I
think my simple header diff is probably good enough.
[← Prev in Thread] Current Thread [Next in Thread→]