Re: [DynInst_API:] commit: further fixes for version definitions

[Josh Stone <jistone@xxxxxxxxxx>]

On 08/25/2015 10:49 AM, Bill Williams wrote:
> 9.0.2 has another issue with out of source builds: version.h was not 
> properly in the include path or the install path. Fixed.
> 
> USERS: I am not tagging 9.0.3 for another 24 hours, minimum. Please send 
> any bug reports on git-head to the list.
> 
> DEVELOPERS: DO NOT commit anything that is not specifically a bug fix 
> for a bug posted to the list to master until 9.0.3 is tagged.

I'm doing some rpmdiffs, and noticed a few things.

symlite is no longer part of the build - is that intentional? In 8.2,
both symlite and symtabAPI would build.  I think this is probably fine.

dynC lost its soname. The attached patch makes it use the new
dyninst_library() to get it back.

In the testsuite, I'm not seeing any proccontrol pic mutatees anymore.
i.e. there's no pc*_pic_none. I don't know what happened there. On the
other hand, a few pc_*.stat_* mutatees showed up new.

That's all I've got. Sorry I didn't test this so detailed earlier, but
we'll get release polishing behind you soon enough...

>From 9b8817659d1de81048bf4302cd185b23c1607ac3 Mon Sep 17 00:00:00 2001
From: Josh Stone <jistone@xxxxxxxxxx>
Date: Tue, 25 Aug 2015 16:26:33 -0700
Subject: [PATCH] dynC: use dyninst_library() to get the proper soname

---
 dynC_API/CMakeLists.txt | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/dynC_API/CMakeLists.txt b/dynC_API/CMakeLists.txt
index f111ab44e6b6..89f9e1dc2d97 100644
--- a/dynC_API/CMakeLists.txt
+++ b/dynC_API/CMakeLists.txt
@@ -9,18 +9,5 @@ include_directories(h
 
 set_source_files_properties(${SRC_LIST} PROPERTIES LANGUAGE CXX)
 add_definitions(-DDYNC_EXPORTS)
-add_library(dynC_API ${SRC_LIST})
-add_library(dynC_API_static STATIC ${SRC_LIST})
-file (GLOB headers "h/*.h")
-
-set_target_properties(dynC_API dynC_API_static PROPERTIES PUBLIC_HEADER "${headers}")
-
-target_link_private_libraries (dynC_API dyninstAPI)
-
-install(TARGETS dynC_API dynC_API_static
-		EXPORT DynCTargets
-		RUNTIME DESTINATION ${INSTALL_LIB_DIR}
-		LIBRARY DESTINATION ${INSTALL_LIB_DIR}		
-		ARCHIVE DESTINATION ${INSTALL_LIB_DIR}
-		PUBLIC_HEADER DESTINATION ${INSTALL_INCLUDE_DIR})
 
+dyninst_library(dynC_API dyninstAPI)
-- 
2.4.3