Branch: refs/heads/bbiiggppiigg/fix-clang-openmp-pthread
Home: https://github.com/dyninst/dyninst
Commit: cf9597c2de7736946c440bb4f69f6a9b5956cbcb
https://github.com/dyninst/dyninst/commit/cf9597c2de7736946c440bb4f69f6a9b5956cbcb
Author: wuxx1279 <bbiiggppiigg@xxxxxxxxx>
Date: 2026-07-03 (Fri, 03 Jul 2026)
Changed paths:
M cmake/tpls/DyninstThreads.cmake
M parseAPI/CMakeLists.txt
Log Message:
-----------
Compile parseAPI with -pthread to fix Clang thread-safety
Dyninst's bundled Sawyer/ROSE only compiles its pool allocator and
shared-pointer reference counting as thread-safe when _REENTRANT is
defined (dataflowAPI/rose/util/Sawyer.h). GCC's -fopenmp defines
_REENTRANT implicitly, but Clang's -fopenmp=libomp does not, so Clang
builds ran the OpenMP-parallel parser with no-op allocator locks. This
corrupted the pool free list and SValue reference counts, causing
assertion failures and segfaults during parallel jump-table symbolic
evaluation (only reproducible with >1 OpenMP thread).
Rather than defining the deprecated _REENTRANT macro directly, set
THREADS_PREFER_PTHREAD_FLAG and link parseAPI against Threads::Threads
when USE_OpenMP is enabled. On GCC/Clang, -pthread defines _REENTRANT
as a documented side effect (see feature_test_macros(7)), so this is
the standard, compiler-independent way to compile threaded code. All
Sawyer/ROSE sources compile into the single parseAPI target and none
of the affected types are exposed in public headers, so scoping the
flag to parseAPI keeps the shared-object layout consistent (no ODR
mismatch) without touching the vendored Sawyer header.
This is an alternative to the global add_compile_definitions(_REENTRANT)
approach in PR #2310, offered for reviewer comparison.
Co-Authored-By: Claude Opus 4.8 <noreply@xxxxxxxxxxxxx>
To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
|