[DynInst_API:] [dyninst/dyninst] 9e6d0c: Revert "Fix failing to write instrumented shared l...


Date: Tue, 30 Jun 2026 11:14:47 -0700
From: kupsch <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 9e6d0c: Revert "Fix failing to write instrumented shared l...
  Branch: refs/heads/kupsch/test-elf
  Home:   https://github.com/dyninst/dyninst
  Commit: 9e6d0c7d29f6d7bbb072130e33cb8bf331761c25
      https://github.com/dyninst/dyninst/commit/9e6d0c7d29f6d7bbb072130e33cb8bf331761c25
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  Revert "Fix failing to write instrumented shared library (#2081) (#2294)"

This reverts commit 1bb8b2698323fb902fcc3e00c6d70bea491b74cc.


  Commit: 000820c755fd51ea209b2840307e5efacfdaa191
      https://github.com/dyninst/dyninst/commit/000820c755fd51ea209b2840307e5efacfdaa191
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  Revert "Clean up logic related to movePHdrFirst (#2165)"

This reverts commit 0d206d395c6deee12bcdaa65614c5f438d0aaeaf.


  Commit: ffe8d7eab5a790de2d66657fff3c2a36996fc703
      https://github.com/dyninst/dyninst/commit/ffe8d7eab5a790de2d66657fff3c2a36996fc703
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: emitElf ctor


  Commit: 897f93760ce48c6b7e3fa4d2eda343037a1951ed
      https://github.com/dyninst/dyninst/commit/897f93760ce48c6b7e3fa4d2eda343037a1951ed
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup: emitElf class

    - typedef -> using
    - default initialization members
    - move data member together in declaration
    - cleanup constructor


  Commit: be2fbcc6f29a72b1d2a2249ae0423ea9f7caddd0
      https://github.com/dyninst/dyninst/commit/be2fbcc6f29a72b1d2a2249ae0423ea9f7caddd0
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  remove everything related to library_adjust

- remove library_adjust, cannotRelocatePhdrs, movePhdrsFirst

- program headers are now placed at the end of the ELF file


  Commit: fa977c927d32c59fbddaa24c7a51aac18d512aee
      https://github.com/dyninst/dyninst/commit/fa977c927d32c59fbddaa24c7a51aac18d512aee
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: variable declarations


  Commit: 3210cf1f50ee1fe17ff9df44a7c10a0ab4e73083
      https://github.com/dyninst/dyninst/commit/3210cf1f50ee1fe17ff9df44a7c10a0ab4e73083
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: remove freebad specific type cast


  Commit: e7e116290bf416ee0b0ce1fd60789822e812979b
      https://github.com/dyninst/dyninst/commit/e7e116290bf416ee0b0ce1fd60789822e812979b
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: comment and error message


  Commit: 4cff3207bd0c7af36cf1e3dd2255a1b51c750819
      https://github.com/dyninst/dyninst/commit/4cff3207bd0c7af36cf1e3dd2255a1b51c750819
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: replace memcpy with assignment


  Commit: 80b65ff7dc08c273f9e1fdac05de39af419cfc85
      https://github.com/dyninst/dyninst/commit/80b65ff7dc08c273f9e1fdac05de39af419cfc85
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: rename variable tmp


  Commit: 363055d05e268a50ce3e8b4deab1ff72944aa46b
      https://github.com/dyninst/dyninst/commit/363055d05e268a50ce3e8b4deab1ff72944aa46b
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: rename variable strtmpl


  Commit: 0e53c17eae84519c4943fe65184570911a31836e
      https://github.com/dyninst/dyninst/commit/0e53c17eae84519c4943fe65184570911a31836e
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: one variable per declaration


  Commit: 989f95eceb695c464bebf527c5fae6dcefc3a6a4
      https://github.com/dyninst/dyninst/commit/989f95eceb695c464bebf527c5fae6dcefc3a6a4
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  fix determination of new section placement

instead of matching the max end offset of loaded segments, to the end offset of
a section, compute the section number with the maximum end offset contained in
segment with the max end offset.  This eliminates not finding a section (and
hence not writing the new sections) if the the last byte of a sement it not
covered by a section.


  Commit: f006fe2a24def16cc54043c15a214052b36801be
      https://github.com/dyninst/dyninst/commit/f006fe2a24def16cc54043c15a214052b36801be
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix location to insert new segment

insert before PT_LOAD segment with higher vaddr or at end


  Commit: 5bfb32f208832809ace5e673785bc691b5e38d1a
      https://github.com/dyninst/dyninst/commit/5bfb32f208832809ace5e673785bc691b5e38d1a
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: move variable declaration near use


  Commit: ff9d60f9b037dac4f3728f1cfd24b53e9e4d2cd0
      https://github.com/dyninst/dyninst/commit/ff9d60f9b037dac4f3728f1cfd24b53e9e4d2cd0
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  define ELF macro constants if undefined

- add definitions of ELF macros that may not be defined in elf.h


  Commit: 7769525c3ae637284c42426bc3e222ffac57d776
      https://github.com/dyninst/dyninst/commit/7769525c3ae637284c42426bc3e222ffac57d776
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  add PT_GNU_PROPERTY to phdrTypeStr


  Commit: 447a8bc5e5fe49d2bec57b2a40bc98871f5ec12b
      https://github.com/dyninst/dyninst/commit/447a8bc5e5fe49d2bec57b2a40bc98871f5ec12b
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix potential uninitialized sym->st_value


  Commit: f77a7b321599c680d2543644ac2b65c487f54766
      https://github.com/dyninst/dyninst/commit/f77a7b321599c680d2543644ac2b65c487f54766
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup: renameSection

- use assignment instead of replace method to replace entire string
- remove renameAll parameter, as it was always false
- pass in only the old name, the new name is computed consistently
  in this function (2nd char changed to 'o')


  Commit: 474bfb76afde1b5c7e3ff374984f5d9b65e3226e
      https://github.com/dyninst/dyninst/commit/474bfb76afde1b5c7e3ff374984f5d9b65e3226e
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: emitElf::driver comments


  Commit: a787de03c16cde22202004af4a1418b82b137dbd
      https://github.com/dyninst/dyninst/commit/a787de03c16cde22202004af4a1418b82b137dbd
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  ignore shstrndx section when computing last loaded scn

- The .shstrtab section is always placed last


  Commit: 0e309505caa85da2376f7391b349f7f36c8e9523
      https://github.com/dyninst/dyninst/commit/0e309505caa85da2376f7391b349f7f36c8e9523
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup secNames vector usage

- add addSection(name) function
- rename secNameIndex to secNameTableTotalBytes
- modernize loops


  Commit: 2cfba58e2af4ab132314c6814d3d615c37a4f915
      https://github.com/dyninst/dyninst/commit/2cfba58e2af4ab132314c6814d3d615c37a4f915
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  make scncount be the section index; start at 1


  Commit: 0194729f4e0d76cc9c865e1cd8e6c49b3b60f5fc
      https://github.com/dyninst/dyninst/commit/0194729f4e0d76cc9c865e1cd8e6c49b3b60f5fc
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  changeMapping: change map value to bool


  Commit: cdfa96acdb122682142b23227e89c2140597b930
      https://github.com/dyninst/dyninst/commit/cdfa96acdb122682142b23227e89c2140597b930
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  remove explicit char* -> string cast


  Commit: e7ab58a8e1edbb10b60b1959b6197c4b2a1063fa
      https://github.com/dyninst/dyninst/commit/e7ab58a8e1edbb10b60b1959b6197c4b2a1063fa
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix log messages


  Commit: 1535420393ff3cbab2b40decc71d8ce1bf9f0fc4
      https://github.com/dyninst/dyninst/commit/1535420393ff3cbab2b40decc71d8ce1bf9f0fc4
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  pass reference to shdr to createnewPhdrRegion

Without this the later used section does not contain the last added
section resulting in the wrong offset.


  Commit: 9bb38412b898c04d6bdc6d58a52acfcbfd8cbedf
      https://github.com/dyninst/dyninst/commit/9bb38412b898c04d6bdc6d58a52acfcbfd8cbedf
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  replace sprintf into buffer with rewrite_printf


  Commit: 8be1eea7e69b0fd99da8506c732335c667907a10
      https://github.com/dyninst/dyninst/commit/8be1eea7e69b0fd99da8506c732335c667907a10
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  modernize loops


  Commit: 7a5c875ca5fc8ae7614efb58b348fc3495761946
      https://github.com/dyninst/dyninst/commit/7a5c875ca5fc8ae7614efb58b348fc3495761946
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/Object-elf.h
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  use old file permissions for created file


  Commit: ba9db62fab4aea597367805a89334e69fba93361
      https://github.com/dyninst/dyninst/commit/ba9db62fab4aea597367805a89334e69fba93361
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  add align_up function


  Commit: 037db8bcdca1255503d2e4e73ccf4bdd091ad4ad
      https://github.com/dyninst/dyninst/commit/037db8bcdca1255503d2e4e73ccf4bdd091ad4ad
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  JK UNDO - add logging


  Commit: ee7d591e9f633dfb1ac70cecb71aef5a37fc95f3
      https://github.com/dyninst/dyninst/commit/ee7d591e9f633dfb1ac70cecb71aef5a37fc95f3
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M cmake/DyninstOptimization.cmake

  Log Message:
  -----------
  JK UNDO - CHANGE DEBUG OPTIMIZATION TO -O0


  Commit: 27ab1e9397bd63915f2e3f28e95f57bb78f725c1
      https://github.com/dyninst/dyninst/commit/27ab1e9397bd63915f2e3f28e95f57bb78f725c1
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  JK UNDO - more logging


Compare: https://github.com/dyninst/dyninst/compare/516791414074...27ab1e9397bd

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 9e6d0c: Revert "Fix failing to write instrumented shared l..., kupsch <=