[DynInst_API:] [dyninst/dyninst] 2870ea: Share progress channel via common; rename env var ...


Date: Mon, 29 Jun 2026 11:40:32 -0700
From: bbiiggppiigg <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 2870ea: Share progress channel via common; rename env var ...
  Branch: refs/heads/bbiiggppiigg/add-progress-reporting
  Home:   https://github.com/dyninst/dyninst
  Commit: 2870ea0d971a7558ec6065c789ca400446de6482
      https://github.com/dyninst/dyninst/commit/2870ea0d971a7558ec6065c789ca400446de6482
  Author: wuxx1279 <bbiiggppiigg@xxxxxxxxx>
  Date:   2026-06-29 (Mon, 29 Jun 2026)

  Changed paths:
    M common/src/debug_common.C
    M common/src/debug_common.h
    M dyninstAPI/src/BPatch/BPatch_binaryEdit.C
    M dyninstAPI/src/Relocation/CodeBuffer.C
    M dyninstAPI/src/Relocation/CodeMover.C
    M dyninstAPI/src/addressSpace.C
    M dyninstAPI/src/binaryEdit.C
    M dyninstAPI/src/debug.C
    M dyninstAPI/src/debug.h
    M dyninstAPI/src/image.C
    M parseAPI/src/Parser-speculative.C

  Log Message:
  -----------
  Share progress channel via common; rename env var to DYNINST_DEBUG_PROGRESS

Move the timestamped progress-reporting implementation out of dyninstAPI's
debug.{h,C} and into common/src/debug_common.{h,C} so parseAPI can use the
same channel directly instead of duplicating it.

  - common now owns common_debug_progress, the progress_printf_int()
    implementation (timestamp prefix + self-gating on the env var), and the
    progress_printf() macro.
  - dyninstAPI's debug.h includes the common header and drops its local
    dyn_debug_progress flag, progress_printf_int, progress_cerr, and the
    progress_printf macro.
  - parseAPI's Parser-speculative.C drops its self-contained gap_progress_report
    timestamp/getenv duplication and routes through the shared progress_printf.

Rename the controlling environment variable DYNINST_REPORT_PROGRESS ->
DYNINST_DEBUG_PROGRESS (and update all comments).

Drop the counter-throttled in-loop progress prints (the "% N == 0" reports in
CodeMover, CodeBuffer, binaryEdit, and the gap-parse loop) since they add
per-iteration overhead on the hot paths; keep only the coarse once-per-phase
markers. Remove the now-unused loop counters.

Strip the redundant "[dyninst] " prefix from every progress message.

Co-Authored-By: Claude Opus 4.8 <noreply@xxxxxxxxxxxxx>



To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 2870ea: Share progress channel via common; rename env var ..., bbiiggppiigg <=