[DynInst_API:] [dyninst/dyninst] 387c01: Revert "Fix failing to write instrumented shared l...


Date: Wed, 24 Jun 2026 07:52:35 -0700
From: kupsch <noreply@xxxxxxxxxx>
Subject: [DynInst_API:] [dyninst/dyninst] 387c01: Revert "Fix failing to write instrumented shared l...
  Branch: refs/heads/kupsch/test-elf
  Home:   https://github.com/dyninst/dyninst
  Commit: 387c012f989a7f64a1e97bbb3f52b74f361b6d65
      https://github.com/dyninst/dyninst/commit/387c012f989a7f64a1e97bbb3f52b74f361b6d65
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  Revert "Fix failing to write instrumented shared library (#2081) (#2294)"

This reverts commit 1bb8b2698323fb902fcc3e00c6d70bea491b74cc.


  Commit: 5f08b7432fb525a23ee4307857410a0d8a904b7e
      https://github.com/dyninst/dyninst/commit/5f08b7432fb525a23ee4307857410a0d8a904b7e
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  Revert "Clean up logic related to movePHdrFirst (#2165)"

This reverts commit 0d206d395c6deee12bcdaa65614c5f438d0aaeaf.


  Commit: 98202bd77f0fe57594d3023ac3b6e0e8f5a488d1
      https://github.com/dyninst/dyninst/commit/98202bd77f0fe57594d3023ac3b6e0e8f5a488d1
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: emitElf ctor


  Commit: 8d6489bd6ccee3b1682d40aa6fbf6f35085b4d73
      https://github.com/dyninst/dyninst/commit/8d6489bd6ccee3b1682d40aa6fbf6f35085b4d73
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup: emitElf class

    - typedef -> using
    - default initialization members
    - move data member together in declaration
    - cleanup constructor


  Commit: c8e0c0dd04820f3762f38abee848e3fd63ebffb3
      https://github.com/dyninst/dyninst/commit/c8e0c0dd04820f3762f38abee848e3fd63ebffb3
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  remove everything related to library_adjust

- remove library_adjust, cannotRelocatePhdrs, movePhdrsFirst

- program headers are now placed at the end of the ELF file


  Commit: 50ee0dc218874309414567852a448e08a6b7e877
      https://github.com/dyninst/dyninst/commit/50ee0dc218874309414567852a448e08a6b7e877
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: variable declarations


  Commit: 7615c3477bddc001d55b125a77f1253e452a1f35
      https://github.com/dyninst/dyninst/commit/7615c3477bddc001d55b125a77f1253e452a1f35
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: remove freebad specific type cast


  Commit: 9deb6d430da982f198d0ad07da631b90e5c48f9f
      https://github.com/dyninst/dyninst/commit/9deb6d430da982f198d0ad07da631b90e5c48f9f
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: comment and error message


  Commit: 4504c62ad5af4aaec096b2c3ed7a336ae7596210
      https://github.com/dyninst/dyninst/commit/4504c62ad5af4aaec096b2c3ed7a336ae7596210
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: replace memcpy with assignment


  Commit: a6ab3d79265966aa335e8792e95766cb269ccbc3
      https://github.com/dyninst/dyninst/commit/a6ab3d79265966aa335e8792e95766cb269ccbc3
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: rename variable tmp


  Commit: 2920e14ae5877d68d8bd2c9acad15da1266cd15b
      https://github.com/dyninst/dyninst/commit/2920e14ae5877d68d8bd2c9acad15da1266cd15b
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: rename variable strtmpl


  Commit: 13e3022e6d89e19a358d6df958f4887df68297e2
      https://github.com/dyninst/dyninst/commit/13e3022e6d89e19a358d6df958f4887df68297e2
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: one variable per declaration


  Commit: fad6d8fb96cef9789bbb91421198d934fac57810
      https://github.com/dyninst/dyninst/commit/fad6d8fb96cef9789bbb91421198d934fac57810
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  fix determination of new section placement

instead of matching the max end offset of loaded segments, to the end offset of
a section, compute the section number with the maximum end offset contained in
segment with the max end offset.  This eliminates not finding a section (and
hence not writing the new sections) if the the last byte of a sement it not
covered by a section.


  Commit: 42c2e1f6a7d3c77fe2483b4a45a2d0bdaffa6ce5
      https://github.com/dyninst/dyninst/commit/42c2e1f6a7d3c77fe2483b4a45a2d0bdaffa6ce5
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix location to insert new segment

insert before PT_LOAD segment with higher vaddr or at end


  Commit: 9a66e777aa532c755c0634c9e6d3210f2ed81f69
      https://github.com/dyninst/dyninst/commit/9a66e777aa532c755c0634c9e6d3210f2ed81f69
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: move variable declaration near use


  Commit: 7fc193a72f16b7a327f3930f1578dcd7edb810f7
      https://github.com/dyninst/dyninst/commit/7fc193a72f16b7a327f3930f1578dcd7edb810f7
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  add PT_GNU_PROPERTY to phdrTypeStr


  Commit: 17803dbac933a3f2e52ade2d4716f31567e3310e
      https://github.com/dyninst/dyninst/commit/17803dbac933a3f2e52ade2d4716f31567e3310e
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix potential uninitialized sym->st_value


  Commit: f4424bb8413a43364daec52b285c99ed95934f71
      https://github.com/dyninst/dyninst/commit/f4424bb8413a43364daec52b285c99ed95934f71
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup: renameSection

- use assignment instead of replace method to replace entire string
- remove renameAll parameter, as it was always false
- pass newName by value and use move


  Commit: fa35ff859279870e983c7589fc94ed1a31242d6d
      https://github.com/dyninst/dyninst/commit/fa35ff859279870e983c7589fc94ed1a31242d6d
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  cleanup: emitElf::driver comments


  Commit: 87e4f5804dabe1356a78f890799f6af1fa7093a3
      https://github.com/dyninst/dyninst/commit/87e4f5804dabe1356a78f890799f6af1fa7093a3
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  add align_up function


  Commit: dfb20b13e867390d1cadda71c58e34f7b5451202
      https://github.com/dyninst/dyninst/commit/dfb20b13e867390d1cadda71c58e34f7b5451202
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  improve renameSection

- pass in only the old name, the new name is computed consistently
  in this function


  Commit: 50f663889f2cf100989b3d538889e9875f965b9a
      https://github.com/dyninst/dyninst/commit/50f663889f2cf100989b3d538889e9875f965b9a
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  ignore shstrndx section computing last loaded scn

- This section is always placed last


  Commit: 809df46e1ef89fa431c22e263132d3ff9aaff88d
      https://github.com/dyninst/dyninst/commit/809df46e1ef89fa431c22e263132d3ff9aaff88d
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  skip .shstrtab for section to insert after


  Commit: 282d369b2ec538a687f3f0035d3ded1c9ae9b066
      https://github.com/dyninst/dyninst/commit/282d369b2ec538a687f3f0035d3ded1c9ae9b066
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  cleanup secNames vector usage

- add addSection(name) function
- rename secNameIndex to secNameTableTotalBytes
- modernize loops


  Commit: e54486440b150a7e634054079eb94fdbc30c8a2d
      https://github.com/dyninst/dyninst/commit/e54486440b150a7e634054079eb94fdbc30c8a2d
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  start scncount at 1


  Commit: 1b5c9893e5757ba3757b281429bab3999db30803
      https://github.com/dyninst/dyninst/commit/1b5c9893e5757ba3757b281429bab3999db30803
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  changeMapping: change map value to bool


  Commit: add9de20ce53058fe711b19dfe9133e508b0c5d6
      https://github.com/dyninst/dyninst/commit/add9de20ce53058fe711b19dfe9133e508b0c5d6
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  replace memcpy with struct assignment


  Commit: 7c18fcb41387650cd52ec3368d7fa7e42139362a
      https://github.com/dyninst/dyninst/commit/7c18fcb41387650cd52ec3368d7fa7e42139362a
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  remove explicit char* -> string cast


  Commit: addb5cd32e5ff3132ffb4cda64537ddbe5fa58c7
      https://github.com/dyninst/dyninst/commit/addb5cd32e5ff3132ffb4cda64537ddbe5fa58c7
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  fix log messages


  Commit: d2cb539731b90623dcc7d8a3724c72f4a376fbe8
      https://github.com/dyninst/dyninst/commit/d2cb539731b90623dcc7d8a3724c72f4a376fbe8
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  JK UNDO - add logging


  Commit: 3b55c80cc53a2630abbe494caa0e8abc67c961fc
      https://github.com/dyninst/dyninst/commit/3b55c80cc53a2630abbe494caa0e8abc67c961fc
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M cmake/DyninstOptimization.cmake

  Log Message:
  -----------
  JK UNDO - CHANGE DEBUG OPTIMIZATION TO -O0


  Commit: 988c550b214a2c0fbc1ad835471d3655d8bcae94
      https://github.com/dyninst/dyninst/commit/988c550b214a2c0fbc1ad835471d3655d8bcae94
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C

  Log Message:
  -----------
  JK UNDO - more logging


  Commit: 516791414074cc11bc418bc42343fd06d23bbfb3
      https://github.com/dyninst/dyninst/commit/516791414074cc11bc418bc42343fd06d23bbfb3
  Author: James A. Kupsch <kupsch@xxxxxxxxxxx>
  Date:   2026-06-23 (Tue, 23 Jun 2026)

  Changed paths:
    M symtabAPI/src/emitElf.C
    M symtabAPI/src/emitElf.h

  Log Message:
  -----------
  JK UNDO more debug logging


Compare: https://github.com/dyninst/dyninst/compare/387c012f989a%5E...516791414074

To unsubscribe from these emails, change your notification settings at https://github.com/dyninst/dyninst/settings/notifications
[← Prev in Thread] Current Thread [Next in Thread→]
  • [DynInst_API:] [dyninst/dyninst] 387c01: Revert "Fix failing to write instrumented shared l..., kupsch <=